Skip to content

Possibility to change tx_payload_buffer_size #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Possibility to change tx_payload_buffer_size #44

merged 1 commit into from
Aug 18, 2021

Conversation

Kacp3r3
Copy link
Contributor

@Kacp3r3 Kacp3r3 commented Jul 28, 2020

Maximum size of the tx paylod buffer was fixed value, there should be possibility to extend this value by user, so i added a new member variable with according setter function.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JDuchniewicz
Copy link

This gave me a headache, and I had to change the define manually because Arduino uses old version of this library.

@krzysztofkrzeslak
Copy link

krzysztofkrzeslak commented May 19, 2021 •
edited
Loading

This gave me a headache, and I had to change the define manually because Arduino uses old version of this library.

@aentinger maybe it's time to consider merging it, as it seems like a bug and I think we were not the only one who came across this issue. At least it should be mentioned somewhere that if long MQTT messages are cut/truncated then you should check the value of this definition, as this is behavior that is being observed in effect.
Thanks!

@aentinger
Copy link
Contributor

I will merge this, if @Kacp3r3 drops 3331408 from this patch.

@Kacp3r3
Copy link
Contributor Author

Kacp3r3 commented May 25, 2021

As you wish

@github-actions
Copy link

Memory usage change @ 79f512f

Board flash % RAM for global variables %
arduino:megaavr:uno2018 🔺 +8 - +8 +0.02 - +0.02 🔺 +2 - +2 +0.03 - +0.03
arduino:samd:mkr1000 🔺 +8 - +8 0.0 - 0.0 🔺 +4 - +4 +0.01 - +0.01
arduino:samd:mkrwifi1010 🔺 0 - +8 0.0 - 0.0 🔺 +4 - +4 +0.01 - +0.01
arduino:samd:nano_33_iot 🔺 +8 - +8 0.0 - 0.0 🔺 +4 - +4 +0.01 - +0.01
Click for full report table
Board examples/WiFiAdvancedCallback
flash		 % examples/WiFiAdvancedCallback
RAM for global variables		 % examples/WiFiEcho
flash		 % examples/WiFiEcho
RAM for global variables		 % examples/WiFiEchoCallback
flash		 % examples/WiFiEchoCallback
RAM for global variables		 % examples/WiFiSimpleReceive
flash		 % examples/WiFiSimpleReceive
RAM for global variables		 % examples/WiFiSimpleReceiveCallback
flash		 % examples/WiFiSimpleReceiveCallback
RAM for global variables		 % examples/WiFiSimpleSender
flash		 % examples/WiFiSimpleSender
RAM for global variables		 %
arduino:megaavr:uno2018 8 0.02 2 0.03 8 0.02 2 0.03 8 0.02 2 0.03 8 0.02 2 0.03 8 0.02 2 0.03 8 0.02 2 0.03
arduino:samd:mkr1000 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01
arduino:samd:mkrwifi1010 0 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 0 0.0 4 0.01 0 0.0 4 0.01 8 0.0 4 0.01
arduino:samd:nano_33_iot 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01 8 0.0 4 0.01
Click for full report CSV 
Board,examples/WiFiAdvancedCallback<br>flash,%,examples/WiFiAdvancedCallback<br>RAM for global variables,%,examples/WiFiEcho<br>flash,%,examples/WiFiEcho<br>RAM for global variables,%,examples/WiFiEchoCallback<br>flash,%,examples/WiFiEchoCallback<br>RAM for global variables,%,examples/WiFiSimpleReceive<br>flash,%,examples/WiFiSimpleReceive<br>RAM for global variables,%,examples/WiFiSimpleReceiveCallback<br>flash,%,examples/WiFiSimpleReceiveCallback<br>RAM for global variables,%,examples/WiFiSimpleSender<br>flash,%,examples/WiFiSimpleSender<br>RAM for global variables,%
arduino:megaavr:uno2018,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03,8,0.02,2,0.03
arduino:samd:mkr1000,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01
arduino:samd:mkrwifi1010,0,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,0,0.0,4,0.01,0,0.0,4,0.01,8,0.0,4,0.01
arduino:samd:nano_33_iot,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01,8,0.0,4,0.01

@aentinger aentinger merged commit 43c1253 into arduino-libraries:master Aug 18, 2021
@aentinger aentinger mentioned this pull request Aug 18, 2021
Closed
@nooj nooj mentioned this pull request Jul 5, 2022
Closed
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 5, 2022
aentinger pushed a commit that referenced this pull request Jul 6, 2022
@nooj @aentinger
Fix buffer overflow introduced in #44.
2be9e7f 
PR #44 introduced a buffer overflow bug that will corrupt the heap if the transmit payload size is increased after any send.
@aentinger aentinger mentioned this pull request Jul 6, 2022
Merged
aentinger added a commit that referenced this pull request Jul 6, 2022
@aentinger @nooj
Fix buffer overflow introduced in #44. (#71)
11a8d5e 
PR #44 introduced a buffer overflow bug that will corrupt the heap if the transmit payload size is increased after any send.

Co-authored-by: Dr. Fred Nugen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kacp3r3 @CLAassistant @JDuchniewicz @krzysztofkrzeslak @aentinger @per1234